Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to reflect the overcommit ratio in the hypervisor crd. This is useful for cortex, so it can calculate how much space is left on a hypervisor. By default, it is assumed that the overcommit for each resource is set to 1. If anything else is specified, it will be reflected in the new
effectiveCapacitystatus field by the kvm node agent. This will allow cortex to take control of the hypervisor overcommit ratio, for now statically, and in the future dynamically.Summary by CodeRabbit