cdi: add resolved edits API - #322
Open
ebendler wants to merge 1 commit into
Open
Conversation
klihub
reviewed
Jul 16, 2026
Author
|
Thanks, @klihub — your comments made the result API clearer. I’ve updated the resolved device-node and mount outputs to embed the effective CDI types with scope metadata, and added coverage for the FIFO zero-value convention. |
elezar
reviewed
Jul 16, 2026
elezar
reviewed
Jul 21, 2026
elezar
reviewed
Jul 21, 2026
elezar
reviewed
Jul 21, 2026
Signed-off-by: Ehren Bendler <ebendler@nvidia.com>
klihub
reviewed
Aug 26, 2026
|
|
||
| // cloneContainerEdits returns a deep copy of edits that can be safely modified | ||
| // without changing the source CDI Spec. | ||
| func cloneContainerEdits(edits *ContainerEdits) (*ContainerEdits, error) { |
Contributor
There was a problem hiding this comment.
nit: why not func (edits *ContainerEdits) Clone() (*ContainerEdits, error) ?
| // any of the devices. Might trigger a cache refresh, in which case any | ||
| // errors encountered can be obtained using GetErrors(). | ||
| func (c *Cache) InjectDevices(ociSpec *oci.Spec, devices ...string) ([]string, error) { | ||
| var unresolved []string |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is that some CDI consumers may not be operating on an OCI container (think sandbox wrappers), but it would be silly to have them all re-implement the code that maps the specfile to the running host when the reference implementations are already doing all of that work.
See also: cncf-tags/container-device-interface-rs#101