Medbay chemical dispenser energy scaling 2: Energy Boogaloo#12270
Open
JackieEstegado wants to merge 4 commits into
Open
Medbay chemical dispenser energy scaling 2: Energy Boogaloo#12270JackieEstegado wants to merge 4 commits into
JackieEstegado wants to merge 4 commits into
Conversation
cmss13-ci
Bot
added
Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
#11073 was a broken implementation. Whenever a new marine joined it would completely refill the energy. Also it caused a different scaling, which was provided for each dispenser on the same energy network, to not affect the medbay's dispensers.
I tested it locally, with current settings, at 50 !marine! pop medbay chem can service about 6-8 moderately hungry medics before XX:20.
I highly advise further testing via TM though.
Also I changed the weird bitwise?? calculation, no idea what that was about.
Explain why it's good for the game
Same as original PR, but hopefully not broken.
Testing Photographs and Procedure
Screenshots & Videos
Put screenshots and videos here with an empty line between the screenshots and the
<details>tags.Changelog
🆑
fix: Fixed medbay chemical dispensers energy fully refilling each time a marine latejoined.
balance: Properly implement medbay chemical dispenser energy scaling.
/:cl: