Skip to content

Fix tacmap runtime for hunting grounds and misc tacmap fixes#12248

Merged
realforest2001 merged 3 commits into
cmss13-devs:masterfrom
Drulikar:tacmap_fixes
May 23, 2026
Merged

Fix tacmap runtime for hunting grounds and misc tacmap fixes#12248
realforest2001 merged 3 commits into
cmss13-devs:masterfrom
Drulikar:tacmap_fixes

Conversation

@Drulikar
Copy link
Copy Markdown
Contributor

@Drulikar Drulikar commented May 18, 2026

About the pull request

This PR does a few things:

  • Fixes https://runtimes.cm-ss13.com/cm13/issues/276 because now Z 14 will exist (its a late loaded Z from hunting grounds when reservation space is already occupied with something else like fax responders - looks like load_new_z was always intended to be a signal handler anyways for a global signal)
  • Micro-optimizes out a redundant istype check in /datum/controller/subsystem/minimaps/fire
  • Fixes an incorrect COMSIG_MOVABLE_Z_CHANGED signal: It lacked oldz and newz arguments, and generally signal senders should be from one source - in this case from onTransitZ.

Explain why it's good for the game

Less runtimes!

Testing Photographs and Procedure

Screenshots & Videos image

Changelog

🆑 Drathek
fix: Fixed some tacmap runtimes with hunting grounds
fix: Fixed a bad COMSIG_MOVABLE_Z_CHANGED call
/:cl:

@Drulikar Drulikar added the Runtime bad list x1000 label May 18, 2026
@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog May 18, 2026
@cmss13-ci cmss13-ci Bot added Fix Fix one bug, make ten more size/XS Denotes a PR that changes 0-19 lines, ignoring generated files. labels May 18, 2026
@cm13-github
Copy link
Copy Markdown
Contributor

cm13-github commented May 20, 2026

Test merge deployment history:

Test Merge Deployed @ 05/20/2026 07:24:34 +00:00:
Server Instance

CM13 Live

Revision

Origin: 03d45a3
Pull Request: 5169c77
Server: db65c06

Test Merge Updated @ 05/20/2026 17:54:17 +00:00:
Server Instance

CM13 Live

Revision

Origin: c95e9b1
Pull Request: 5169c77
Server: 3280e9154949182c4e51ee27602a16ed75001565

Test Merge Updated @ 05/20/2026 22:56:32 +00:00:
Server Instance

CM13 Live

Revision

Origin: a46fad7
Pull Request: 5169c77
Server: fb7be4f1bfbd6edaf862a67b770100fb826b4fa6

Test Merge Updated @ 05/20/2026 23:27:20 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3400df7
Pull Request: 5169c77
Server: b0cf5e6

Test Merge Updated @ 05/20/2026 23:58:08 +00:00:
Server Instance

CM13 Live

Revision

Origin: 05f844d
Pull Request: 5169c77
Server: e05d3bffb5af57228f87f5ea7e53f0aaf8efcd45

Test Merge Updated @ 05/21/2026 00:28:58 +00:00:
Server Instance

CM13 Live

Revision

Origin: f4f02d0
Pull Request: 5169c77
Server: 66f94a611a94e93292e3ee078228929c17a40a79

Test Merge Updated @ 05/21/2026 00:59:48 +00:00:
Server Instance

CM13 Live

Revision

Origin: 58fc60a
Pull Request: 5169c77
Server: 42ff026

Test Merge Updated @ 05/21/2026 01:30:42 +00:00:
Server Instance

CM13 Live

Revision

Origin: 2104086
Pull Request: 5169c77
Server: 34b682f2ec12fe202bbfed0650de5dd8fdb3d171

Test Merge Updated @ 05/21/2026 04:32:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 583cbcd
Pull Request: 5169c77
Server: 8370b689eb8f7a8fc27dec335a12d1e370909568

Test Merge Updated @ 05/22/2026 00:39:01 +00:00:
Server Instance

CM13 Live

Revision

Origin: 583cbcd
Pull Request: 5169c77
Server: e6ee75c

Test Merge Updated @ 05/22/2026 01:40:04 +00:00:
Server Instance

CM13 Live

Revision

Origin: 579457c
Pull Request: 5169c77
Server: 5077583f3db971aac04b915045a3e4cff448258b

Test Merge Updated @ 05/22/2026 04:11:23 +00:00:
Server Instance

CM13 Live

Revision

Origin: 776c4a6
Pull Request: 5169c77
Server: aa6b594cf5f372f9fd261c17b9cc08289e69f3e3

Test Merge Updated @ 05/22/2026 14:14:57 +00:00:
Server Instance

CM13 Live

Revision

Origin: 6d8a35f
Pull Request: 5169c77
Server: f32a9a785e7b27a2c504f88b437161b3b6568e2a

Test Merge Updated @ 05/22/2026 14:45:49 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7cd9b89
Pull Request: 5169c77
Server: 432c8f6af683f307ca5e93d52e80d1107d620c53

Test Merge Updated @ 05/22/2026 22:18:38 +00:00:
Server Instance

CM13 Live

Revision

Origin: 7cd9b89
Pull Request: 5169c77
Server: 753f1f6

Test Merge Updated @ 05/23/2026 03:50:39 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4412c87
Pull Request: 5169c77
Server: f93494153429cf9e2fd1691a41e3701ac63e9908

Test Merge Updated @ 05/23/2026 04:51:36 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4412c87
Pull Request: 5169c77
Server: 27cfb8a

Test Merge Updated @ 05/23/2026 16:14:49 +00:00:
Server Instance

CM13 Live

Revision

Origin: 4412c87
Pull Request: 5169c77
Server: 3156670

Test Merge Updated @ 05/23/2026 16:25:09 +00:00:
Server Instance

CM13 Live

Revision

Origin: 3d558ec
Pull Request: 5169c77
Server: f9f92f73e48de6d52d3be8c3efda2f16b4ec271b

Test Merge Removed @ 05/23/2026 16:54:29 +00:00:
Server Instance

CM13 Live

@github-project-automation github-project-automation Bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog May 23, 2026
@realforest2001 realforest2001 added this pull request to the merge queue May 23, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 23, 2026
@realforest2001 realforest2001 added this pull request to the merge queue May 23, 2026
Merged via the queue into cmss13-devs:master with commit 4643a86 May 23, 2026
28 checks passed
@github-project-automation github-project-automation Bot moved this from Partially Approved / Mergeable to Merged in Review Backlog May 23, 2026
cmss13-ci Bot added a commit that referenced this pull request May 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fix one bug, make ten more Runtime bad list x1000 size/XS Denotes a PR that changes 0-19 lines, ignoring generated files. Testmerge Candidate we'll test this while you're asleep and the server has 10 players

Projects

Status: Merged

Development

Successfully merging this pull request may close these issues.

3 participants