Skip to content

filing cabinet fixes#12221

Open
kitchenenthusiast wants to merge 11 commits into
cmss13-devs:masterfrom
kitchenenthusiast:the_jones_files
Open

filing cabinet fixes#12221
kitchenenthusiast wants to merge 11 commits into
cmss13-devs:masterfrom
kitchenenthusiast:the_jones_files

Conversation

@kitchenenthusiast
Copy link
Copy Markdown

@kitchenenthusiast kitchenenthusiast commented May 14, 2026

About the pull request

fixes #11955 ; one message per failed object placement
fixes #11808 ; runtime gone! wow!!!
fixes #8886 ; fixes state inheritance for lil doc cabinets

backend refactor of filing cabinet code to fix some minor bugs + improve runtime performance. see next section for more on that.

Explain why it's good for the game

less chat spam
fix blank doc generation runtime!!! wow!!!
fixing icon consistency issues;
fixes some edge cases, namely:

  • in the event a research note isn't safely converted when putting into sorting cabinet, it no longer gets "eaten" from user's hands
  • patched some potential loops in medical and security record population
  • garbage collecting of duplicate reports put into the automatic cabinet so less memory leakage happens
  • fixed some potential spots for runtimes in the event research note data was uninitialized

Testing Photographs and Procedure

hitting with wrench wrenches/unwrenches as expected and generates no in-chat text
hitting with a fileable item files the item and generates in-text notification you filed the item. item also correctly goes to contents
hitting with a jones politely instructs you just once in-text that you can't put a jones/rangefinder/revolver in the filing cabinet.
placing a doc in the mini cabinet in CIC doesn't cause it to become a full-sized cabinet
clicking to get a doc in the doc cabinet, then hitting "cancel" doesn't generate a blank paper and clears the window correctly.
research papers still sort and work the same
med and sec records still work the same

the UI also doesn't update in this case to reflect that but it didn't in the first place; you just can't pull anything out. server state refuses to give nonexistent paper to user when user is not adjacent. when adjacent, user gets the message the cabinet is empty.

reflecting that in the UI/updating the UI probably will have to be done when the HTML window for filing cabinets is re-done.

Changelog

🆑
fix: Filing cabinets no longer give 6 messages when you try to put an unfilable item in them
fix: Half-sized document cabinets no longer shrink when you put a paper into them
/:cl:

@github-project-automation github-project-automation Bot moved this to Awaiting Review in Review Backlog May 14, 2026
@cmss13-ci cmss13-ci Bot added Missing Changelog Maintainers always document their changes. size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels May 14, 2026
@kitchenenthusiast kitchenenthusiast marked this pull request as draft May 14, 2026 19:38
@kitchenenthusiast kitchenenthusiast marked this pull request as ready for review May 14, 2026 20:12
@kitchenenthusiast kitchenenthusiast marked this pull request as draft May 15, 2026 19:17
@kitchenenthusiast
Copy link
Copy Markdown
Author

i have decided, in fact, i want to root out like two more runtimes, thank you for your patience

@cmss13-ci cmss13-ci Bot added Fix Fix one bug, make ten more and removed Missing Changelog Maintainers always document their changes. labels May 17, 2026
@cmss13-ci cmss13-ci Bot added size/L Denotes a PR that changes 200-799 lines, ignoring generated files. and removed size/M Denotes a PR that changes 50-199 lines, ignoring generated files. labels May 18, 2026
@kitchenenthusiast kitchenenthusiast marked this pull request as ready for review May 18, 2026 03:39
realforest2001
realforest2001 previously approved these changes May 18, 2026
@github-project-automation github-project-automation Bot moved this from Awaiting Review to Partially Approved / Mergeable in Review Backlog May 18, 2026
Copy link
Copy Markdown
Contributor

@kiVts kiVts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good PR

Comment thread code/modules/paperwork/filingcabinet.dm Outdated
@github-project-automation github-project-automation Bot moved this from Partially Approved / Mergeable to Changes Requested in Review Backlog May 19, 2026
@kiVts kiVts marked this pull request as draft May 19, 2026 00:04
@kitchenenthusiast kitchenenthusiast marked this pull request as ready for review May 22, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Fix Fix one bug, make ten more size/L Denotes a PR that changes 200-799 lines, ignoring generated files.

Projects

Status: Changes Requested

3 participants