filing cabinet fixes#12221
Open
kitchenenthusiast wants to merge 11 commits into
Open
Conversation
Author
|
i have decided, in fact, i want to root out like two more runtimes, thank you for your patience |
realforest2001
previously approved these changes
May 18, 2026
kiVts
requested changes
May 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About the pull request
fixes #11955 ; one message per failed object placement
fixes #11808 ; runtime gone! wow!!!
fixes #8886 ; fixes state inheritance for lil doc cabinets
backend refactor of filing cabinet code to fix some minor bugs + improve runtime performance. see next section for more on that.
Explain why it's good for the game
less chat spam
fix blank doc generation runtime!!! wow!!!
fixing icon consistency issues;
fixes some edge cases, namely:
Testing Photographs and Procedure
hitting with wrench wrenches/unwrenches as expected and generates no in-chat text
hitting with a fileable item files the item and generates in-text notification you filed the item. item also correctly goes to contents
hitting with a jones politely instructs you just once in-text that you can't put a jones/rangefinder/revolver in the filing cabinet.
placing a doc in the mini cabinet in CIC doesn't cause it to become a full-sized cabinet
clicking to get a doc in the doc cabinet, then hitting "cancel" doesn't generate a blank paper and clears the window correctly.
research papers still sort and work the same
med and sec records still work the same
the UI also doesn't update in this case to reflect that but it didn't in the first place; you just can't pull anything out. server state refuses to give nonexistent paper to user when user is not adjacent. when adjacent, user gets the message the cabinet is empty.
reflecting that in the UI/updating the UI probably will have to be done when the HTML window for filing cabinets is re-done.
Changelog
🆑
fix: Filing cabinets no longer give 6 messages when you try to put an unfilable item in them
fix: Half-sized document cabinets no longer shrink when you put a paper into them
/:cl: