Fix DSU timer freeze on tab switch and refactor assets (externalize CSS/JS)#1
Open
raissanjay wants to merge 2 commits into
Open
Fix DSU timer freeze on tab switch and refactor assets (externalize CSS/JS)#1raissanjay wants to merge 2 commits into
raissanjay wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background / Issue
When switching browser tabs, JavaScript's setInterval can be throttled or paused, causing our DSU "Meeting Time" and per-speaker timers to stop counting until you return.
In addition, all of our CSS and JS was inlined in index.html, making it hard to maintain.
What this PR does
Fixes the timer freeze
Date.now() - startTimestampon each tick, rather than simply doingcounter++.Externalizes assets
<head>intodsu/style.css(pretty-printed & organized).<script>intodsu/script.js, with clear function boundaries and comments.dsu/index.htmlto be a clean, well-indented template that simply links tostyle.cssandscript.js.Keeps behavior identical
How to test
Please let me know if you spot any edge cases or styling tweaks—otherwise this is ready to merge!