-
Notifications
You must be signed in to change notification settings - Fork 42
(draft) optimize: caching + minor opts #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
1. with saving/loading cache to/from disk 2. fixes the missing client.Close
optimizes getSymbolByLocation() and filterLocalSymbols()
|
|
||
| import "github.com/cloudwego/abcoder/lang/lsp" | ||
|
|
||
| func isFuncLike(sk lsp.SymbolKind) bool { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Who is the caller of these three functions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
skipTokenForDependency and getSymbolByLocation in Collect.go. I thought this might help with clarifying & maintaining consistency tho.
|
The optimizations are real, but let's not merge this for now. The first commit was a major overhaul of Collect. I guess it could wait until the tree-sitter extension is merged, so we do not have two overhauls going on at the same time. |
|
Please add [WIP] in the PR title or change to draft PR when not planning to merge it |
What type of PR is this?
优化合集
效果 相关讨论
还有一些不确定要不要 push
Check the PR title.
(Optional) Translate the PR title into Chinese.
(Optional) More detailed description for this PR(en: English/zh: Chinese).
en:
zh(optional):
(Optional) Which issue(s) this PR fixes:
(optional) The PR that updates user documentation: