Remove hardcoded test mnemonic from hardhat.config.ts and .env.example and enforce explicit mnemonic environment variables #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The Vulnerability Description: The codebase shipped a well-known test mnemonic ("test test ... junk") in hardhat.config.ts and .env.example, which if used in CI, local deploys, or production fully compromises all derived private keys and allows attackers to sign transactions, upgrade contracts, or drain funds.
This Fix: The patch removes the hardcoded default mnemonic from the config, clears example mnemonic values in .env.example, and forces an explicit mnemonic to be provided by throwing an error when it's missing, preventing accidental use of insecure defaults.
The Cause of the Issue: The project implicitly fell back to a public, well-known test mnemonic when environment variables were absent, creating an insecure default that could silently be used in CI or deployments.
The Patch Implementation: Removed DEFAULT_MNEMONIC from hardhat.config.ts, updated mnemonicOrDefault() to throw if no mnemonic is set and return the provided mnemonic, and replaced test mnemonics in .env.example with empty values (files changed: hardhat.config.ts and .env.example).
Vulnerability Details
Code Snippets
How to Modify the Patch
You can modify this patch by using one of the two methods outlined below. We recommend using the
@zeropath-aibot for updating the code. If you encounter any bugs or issues with the patch, please report them here.Ask
@zeropath-ai!To request modifications, please post a comment beginning with
@zeropath-aiand specify the changes required.@zeropath-aiwill then implement the requested adjustments and commit them to the specified branch in this pull request. Our bot is capable of managing changes across multiple files and various development-related requests.Manually Modify the Files