Skip to content

chore: Split public and internal interface#234

Merged
pan-kot merged 1 commit into
mainfrom
public-interfaces-contract
Jul 13, 2026
Merged

chore: Split public and internal interface#234
pan-kot merged 1 commit into
mainfrom
public-interfaces-contract

Conversation

@pan-kot

@pan-kot pan-kot commented Jul 10, 2026

Copy link
Copy Markdown
Member

Description

Same changes as in components repo: cloudscape-design/components#4703

How has this been tested?

  • Dry-run to live (7927754436)
Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot force-pushed the public-interfaces-contract branch from 5542cf5 to dc0b07f Compare July 11, 2026 13:12
@pan-kot pan-kot marked this pull request as ready for review July 11, 2026 13:23
@pan-kot pan-kot requested a review from a team as a code owner July 11, 2026 13:23
@pan-kot pan-kot requested review from NathanZlion and removed request for a team July 11, 2026 13:23
@NathanZlion

NathanZlion commented Jul 13, 2026

Copy link
Copy Markdown
Member

why is this one still importing LegendItem internal one?

import { LegendItem } from "../../internal/components/interfaces";

If we're moving it, shouldn't we move the whole thing instead of defining it in 2 places, is this intended for instance for LegendItem and the other chart props @pan-kot

Discussed internally

@pan-kot pan-kot added this pull request to the merge queue Jul 13, 2026
Merged via the queue into main with commit 53bc6e7 Jul 13, 2026
47 of 49 checks passed
@pan-kot pan-kot deleted the public-interfaces-contract branch July 13, 2026 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants