Skip to content

chore: Removes dependency on base component types#231

Merged
pan-kot merged 1 commit into
mainfrom
fix-base-component-dep
Jun 18, 2026
Merged

chore: Removes dependency on base component types#231
pan-kot merged 1 commit into
mainfrom
fix-base-component-dep

Conversation

@pan-kot

@pan-kot pan-kot commented Jun 18, 2026

Copy link
Copy Markdown
Member

Description

Required for cloudscape-design/components#4646.

The base component type is not exposed from the components and must not be imported via /internal namespace.

In fact, this type is not even needed - as chart series detail is an internal component and the base component props are not being used by the upstream code. Another component, chart series marker is technically exposed - but the base props were not used by the component itself - and there is no need to support id and className for it.

How has this been tested?

Review checklist

The following items are to be evaluated by the author(s) and the reviewer(s).

Correctness

  • Changes include appropriate documentation updates.
  • Changes are backward-compatible if not indicated, see CONTRIBUTING.md.
  • Changes do not include unsupported browser features, see CONTRIBUTING.md.
  • Changes were manually tested for accessibility, see accessibility guidelines.

Security

Testing

  • Changes are covered with new/existing unit tests?
  • Changes are covered with new/existing integration tests?

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@pan-kot pan-kot requested a review from a team as a code owner June 18, 2026 11:41
@pan-kot pan-kot requested review from jperals and removed request for a team June 18, 2026 11:41
@pan-kot pan-kot added this pull request to the merge queue Jun 18, 2026
Merged via the queue into main with commit a98b555 Jun 18, 2026
45 of 46 checks passed
@pan-kot pan-kot deleted the fix-base-component-dep branch June 18, 2026 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants