feat(greenhouse): optimize plugin fetching and loading strategies#1540
Draft
feat(greenhouse): optimize plugin fetching and loading strategies#1540
Conversation
🦋 Changeset detectedLatest commit: f2c0713 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
79e52ab to
c10f5d2
Compare
46ee22f to
0665481
Compare
880c7e4 to
ab0d2c2
Compare
- Add dynamic imports for plugins to reduce initial bundle size - Implement module-level caching to eliminate loading flicker on return visits - Use remountDeps to ensure clean URL state when switching between plugins - Update TypeScript declarations for plugin modules - Export PluginModule type from each plugin for better documentation
ab0d2c2 to
f2c0713
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Optimize plugin loading with dynamic imports and improve navigation between plugins. Plugins now load on-demand instead of being bundled upfront, reducing initial bundle size by 66%. Added module caching to eliminate loading spinners on return visits. Fixed URL state pollution when switching between plugins using TanStack Router's
remountDeps. Also filters plugins server-side to fetch only UI plugins.Changes Made
greenhouse.sap/ui-plugin=truelabel (server-side)remountDepsto ensure clean URL state when switching pluginsRelated Issues
Testing Instructions
pnpm ipnpm devChecklist