Skip to content

harden missing file handling during gadget export - #264

Merged
maxwellpeterson merged 1 commit into
mainfrom
mpeterson/export-no-module
Aug 19, 2026
Merged

harden missing file handling during gadget export#264
maxwellpeterson merged 1 commit into
mainfrom
mpeterson/export-no-module

Conversation

@maxwellpeterson

@maxwellpeterson maxwellpeterson commented Aug 18, 2026

Copy link
Copy Markdown
Member
  • skip server-side discovery if server.js does not exist
  • don't advertise default browser-mode export formats if client.js does not exist

@github-actions github-actions Bot added the kernel Changes to the Workshop kernel label Aug 18, 2026
@github-actions

Copy link
Copy Markdown

Preview: pr264-mpeterson-exp-3283fd54

https://pr264-mpeterson-exp-3283fd54-router.cloudflare-os-previews.workers.dev

Dashboard · deleted when this PR closes

@maxwellpeterson
maxwellpeterson marked this pull request as ready for review August 19, 2026 00:09
devin-ai-integration[bot]

This comment was marked as resolved.

@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/export-no-module branch from f97e950 to f97c3e4 Compare August 19, 2026 00:43
devin-ai-integration[bot]

This comment was marked as resolved.

- skip server-side discovery if server.js does not exist
- don't advertise default export formats if server.js or client.js does not exist
@maxwellpeterson
maxwellpeterson force-pushed the mpeterson/export-no-module branch from f97c3e4 to f23039f Compare August 19, 2026 00:53

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Devin Review found 1 new potential issue.

View 1 additional finding in Devin Review.

Open in Devin Review

Comment thread packages/workshop-backend/src/overseer.ts
Comment thread packages/workshop-backend/src/overseer.ts
@maxwellpeterson
maxwellpeterson merged commit 6478a14 into main Aug 19, 2026
12 checks passed
@maxwellpeterson
maxwellpeterson deleted the mpeterson/export-no-module branch August 19, 2026 04:08
tosaka07 added a commit to tosaka07/cloudflare-os that referenced this pull request Aug 20, 2026
* upstream/main:
  Retry pure user-DO reads once across a reset (cloudflare#263)
  Simplify MCP discovery flows (cloudflare#269)
  harden missing file handling during gadget export (cloudflare#264)
  Support large MCP portal catalogs (cloudflare#170)
darjss pushed a commit to darjss/cloudflare-os-erxes that referenced this pull request Aug 26, 2026
- skip server-side discovery if server.js does not exist
- don't advertise default export formats if server.js or client.js does not exist
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kernel Changes to the Workshop kernel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants