Fix frontend build cleanup on Windows - #252
Open
snowyukitty wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Fixes #250.
Replace the POSIX-only
rmexecutable in theworkshop-frontendVite+clean:disttask with Node's built-in recursive filesystem removal. This lets the frontend build, and thereforepnpm lint, run on Windows without changing the task's cleanup behavior.Why is this obviously correct and trivially verifiable?
fs.rmSync(..., { recursive: true, force: true })has the two properties this task needs fromrm -rf: it removes the completedisttree and does not fail when the path is absent. Node is already the runtime for every repository task, so the replacement adds no dependency or platform-specific executable. The task remains uncached and remains thebuilddependency; only its command changes.Verification on Windows 11 with Node 24.19.0 and pnpm 11.17.0:
pnpm exec vp run -F @gadgets/workshop-frontend --no-cache buildfailed withFailed to find executable rm;dist/before the run was removed;pnpm lintcompleted successfully (existing warnings only).AI tools assisted the investigation, patch drafting, and review. The failure and verification results above were reproduced locally.
Checklist