Repository navigation
Conversation
Contributor
|
All contributors have signed the CLA ✍️ ✅ |
🦋 Changeset detectedLatest commit: 460e003 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Author
|
I have read the CLA Document and I hereby sign the CLA |
|
This pull request was not reviewed automatically because its author does not have write access to this repository. A maintainer with write access can start a review by commenting |
for...in over the import, export, and onBroken tables also visits enumerable properties added to Array.prototype, so shutdown called abort() on them and threw. Use Object.keys(), which still skips holes and keeps negative indexes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
vdhanan
force-pushed
the
fix-array-prototype-session-tables
branch
from
October 19, 2026 07:40
c7346eb to
460e003
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
capnweb tracks each session's stubs in arrays. when a session shuts down, it loops over those arrays with
for...in, which also visits any enumerable property a library added toArray.prototype. drizzle-kit adds one (random), so shutting down a session throwsthis.imports[i].abort is not a function, andgetStats()reports too many stubs.this loops over
Object.keys()instead, which returns only the arrays' own entries. the new test fails without the fix.🤖 Generated with Claude Code