Remove Turbo, Improve formatting consistency, and other fixes#1926
Remove Turbo, Improve formatting consistency, and other fixes#1926StephaneTrebel wants to merge 6 commits intomainfrom
Conversation
StephaneTrebel
added
technical debt
|
🤖 Hey ! The @cpn-console/eslint-config (v1.0.2) package already exists on npm but the source code has changed, you should consider updating the package version. The version update warning should be ignored in the case of modifications that do not affect the code once it has been built, such as code formatting, etc... |
|
🤖 Hey ! The security scan report for the current pull request is available here. |
StephaneTrebel
force-pushed
the
improve-formatting
branch
from
193d884 to
dbb5cc1
Compare
More hassle than it's worth for our needs
This means we are getting rid of prettier here, for now. Consistency above all.
They will ultimately be removed from the repository. Better start to remove them here.
StephaneTrebel
force-pushed
the
improve-formatting
branch
from
dbb5cc1 to
4b6d330
Compare
|
shikanime
left a comment
shikanime
left a comment
There was a problem hiding this comment.
IMHO, j'aurais split la PR en "fix formatting", "upgrade node", "drop kube CI support" et "remove turbo".
| component-tests: | ||
| uses: ./.github/workflows/job-tests-component.yml | ||
| if: ${{ needs.path-filter.outputs.apps == 'true' || needs.path-filter.outputs.packages == 'true' || needs.path-filter.outputs.ci == 'true' }} | ||
| needs: | ||
| - path-filter | ||
| - expose-vars | ||
| with: | ||
| NODE_VERSION: ${{ needs.expose-vars.outputs.NODE_VERSION }} | ||
| BROWSERS: "${{ github.base_ref == 'main' && 'chrome,firefox' || 'firefox' }}" | ||
|
|
There was a problem hiding this comment.
Est-ce qu'on veut vraiment enlever les ct en meme temps que tout le reste tout?
|
|
||
| env: | ||
| NODE_VERSION: 22.14.0 | ||
| NODE_VERSION: 24.13.1 |
There was a problem hiding this comment.
(Picky) J'aurais prefere split ca en differente PRs.
| "scripts": { | ||
| "build": "nest build", | ||
| "format": "prettier --write \"src/**/*.ts\" \"test/**/*.ts\"", | ||
| "format": "eslint ./ --fix", |
There was a problem hiding this comment.
Il y a aussi eslint-plugin-format de antfu si on l'utilise pas deja
2 participants
Référence: https://github.com/cloud-pi-native/documentation-interne-socle/blob/main/Architectural%20Decision%20Record/008-nodejs-tooling.md
turboserver-nestjssur la même stratégie de formattage du code (antfuet donceslint-formatting)Suivant les retours on basculera éventuellement sur un "vrai" outil de gestion de monorepo comme Nx (ou autre)