Skip to content

create directories - #34

Merged
wz-gsa merged 1 commit into
mainfrom
directory-structure-fix
Jul 30, 2025
Merged

create directories#34
wz-gsa merged 1 commit into
mainfrom
directory-structure-fix

Conversation

@dandersonsw

Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:

  • Create the wrk directory and the zap-config directory at the same time

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, fixing creation of directories for files

@wz-gsa wz-gsa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wz-gsa
wz-gsa merged commit 261a047 into main Jul 30, 2025
2 checks passed
@wz-gsa
wz-gsa deleted the directory-structure-fix branch July 30, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants