Skip to content

declaring as a volume is necessary - #33

Merged
dandersonsw merged 1 commit into
mainfrom
use-volume
Jul 29, 2025
Merged

declaring as a volume is necessary#33
dandersonsw merged 1 commit into
mainfrom
use-volume

Conversation

@dandersonsw

Copy link
Copy Markdown
Contributor

Changes proposed in this pull request:

  • Need to declare the volume so that the directory can be used at runtime

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None, setting volume

@wz-gsa wz-gsa self-assigned this Jul 29, 2025

@wz-gsa wz-gsa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dandersonsw
dandersonsw merged commit b0c1711 into main Jul 29, 2025
2 checks passed
@dandersonsw
dandersonsw deleted the use-volume branch July 29, 2025 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants