Feature: CORE-37264 node manager#34
Merged
Merged
Conversation
twallis-cpr
requested review from
nnarain-cpr and
tonybaltovski
and removed request for
a team
twallis-cpr
changed the title
nnarain-cpr
reviewed
May 26, 2026
nnarain-cpr
approved these changes
May 26, 2026
… to a node_manager API, add ability to encode a specific bundle ID
| slot_id = i; | ||
| something_to_send = true; | ||
| } | ||
| else if (bundle_desc->last_send_ms <= oldest_timestamp) |
Member
There was a problem hiding this comment.
Should this be < to avoid last bundle always being sent?
Contributor
Author
There was a problem hiding this comment.
We do want to send the oldest bundle in this case (the periodic bundle send is a separate ticket). Right now it's based on the hierarchy in node_manager.h
tonybaltovski
approved these changes
May 26, 2026
Member
tonybaltovski
left a comment
tonybaltovski
left a comment
There was a problem hiding this comment.
LGTM. Just one comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of the larger proton re-architecture here (internal CPR/OTTO employee eyes only 👀 )
This re-creates the node manager API as a single read/write interface. The node type has a pointer to the registry and will parse through it to determine which bundles to send, and mark which endpoint to send it to (along with which transport type).
It is now up to the user to handle the actual mechanics of sending/receiving data from the transports, this is an attempt to enforce the "transports belong to the owner" principle that most embedded libraries have, rather than relying on users to conform to our callback structure. This prevents proton from being involved in things like interrupts, callbacks, etc.