Add idempotency core request lifecycle API with pluggable store#35
Conversation
Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/e82ed90f-5737-4d71-b0d6-688eab1aa882 Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/e82ed90f-5737-4d71-b0d6-688eab1aa882 Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
Agent-Logs-Url: https://github.com/cl-sdk/io.github.cl-sdk.wst/sessions/e82ed90f-5737-4d71-b0d6-688eab1aa882 Co-authored-by: diasbruno <362368+diasbruno@users.noreply.github.com>
diasbruno
force-pushed
the
copilot/implement-idempotency-key
branch
from
65ee48a to
6b1a664
Compare
|
@copilot This code is not good. We need to provide clean interface for the user as in the The |
Addressed in |
|
@copilot remove the routing and anything related to middleware. Let's first work on the core of the idempotency. |
| (:documentation "Hash-table-backed in-memory idempotency engine. | ||
| Not thread-safe.")) | ||
|
|
||
| (defun make-memory-idempotency-engine (&key |
There was a problem hiding this comment.
@copilot we don't need this function because all of the defaults are already present on the base class and the default table is in subclass.
There was a problem hiding this comment.
Updated in d1868e5: removed make-memory-idempotency-engine and switched usage to direct (make-instance 'io.github.cl-sdk.wst.idempotency.memory-store:memory-idempotency-engine ...) since defaults are already provided by the classes.
| io.github.cl-sdk.wst.idempotency.store:delete-entry for storage behavior. | ||
| For a complete engine implementation, specialize all three methods.")) | ||
|
|
||
| (defgeneric idempotency-engine-store (engine) |
There was a problem hiding this comment.
Updated in 59bfceb: removed the idempotency-engine-store generic and stopped exporting it from idempotency/package.lisp.
Uh oh!
There was an error while loading. Please reload this page.