Skip to content

Use 5+ minutes as the minimum drive time #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jacebrowning merged 1 commit into from
Jun 4, 2026
Merged

Use 5+ minutes as the minimum drive time #42

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/visit/visit.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,9 @@ function parkingInstructionDashOnboardMetrics(multimodal) {
return `${rideM} min ride`;
}

/** Minimum drive badge when the user's location is on the map (e.g. **5+ min drive**). */
const PARKING_DRIVE_ESTIMATE_DISPLAY_MIN_MINUTES = 5;

/** Right-column copy: haversine drive from the user's location (`parkingRoutePace.driveMilesPerHour`). */
function parkingInstructionDriveEstimateMetrics(
fromLat,
Expand All @@ -168,7 +171,10 @@ function parkingInstructionDriveEstimateMetrics(
const mph = resolveParkingRoutePace(
appData?.parkingRoutePace,
).driveMilesPerHour;
const min = Math.max(1, Math.round((miles / mph) * 60));
const min = Math.max(
PARKING_DRIVE_ESTIMATE_DISPLAY_MIN_MINUTES,
Math.round((miles / mph) * 60),
);
return `${min}+ min drive`;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/visit.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,12 @@ test.describe("Parking map (#/visit)", () => {

await expect(driveBadge).not.toHaveText("15+ min drive");
await expect(driveBadge).toHaveText(/\d+\+ min drive/);

const floored = await page.evaluate(() => {
const fn = globalThis.__parkingInstructionDriveEstimateMetricsForTest;
return fn?.(42.97, -85.68, 42.9701, -85.6801) ?? "";
});
expect(floored).toBe("5+ min drive");
});

test("preserves destination and category filters in the URL across reload", async ({
Expand Down
Loading