Conversation
Adds `.github/workflows/bench.yml` for on-demand benchmark runs on
the GitHub Actions Ubuntu x86_64 runner. Trigger via the Actions tab
or `gh workflow run bench --ref <branch-or-sha>`.
The shared runner produces noisy numbers (~5–15% variance) so this
isn't a regression gate, but it's useful for:
- First-pass validation that the x86 SSE path actually beats
scalar before we invest in dedicated benchmarking hardware.
- Relative `base85` vs `base85-simd` comparison on the same
silicon (noise mostly cancels).
Workflow steps:
- Print CPU model + available SIMD feature flags from /proc/cpuinfo.
- Install stable Rust + Swatinem/rust-cache@v2.
- `cargo bench --bench encode --locked` with output captured.
- Print a `time:` summary at the end of the log.
- Upload `bench-output.txt` and the full criterion HTML report
(`target/criterion/`) as a 30-day artifact.
Manual-only (`workflow_dispatch`) so it doesn't run on every PR
(the bench takes ~5–10 min and we don't gate on its numbers).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds `.github/workflows/bench.yml` for on-demand benchmark runs on the GitHub Actions Ubuntu x86_64 runner. Manual-only trigger (`workflow_dispatch`) so it doesn't run on every PR (~5–10 min).
Why
Until we have a dedicated x86 box, the GHA Ubuntu runner is the easiest way to validate that the x86 SSE work in #6 actually beats scalar on real silicon (Rosetta only confirms correctness, not perf). Numbers from a shared runner are noisy (~5–15% variance), but `base85` vs `base85-simd` are measured on the same hardware in the same run so the noise mostly cancels.
Usage
```sh
from CLI
gh workflow run bench --ref x86-simd
or from the Actions tab in the UI, choose a branch/sha
```
The job: