Add uint8_t static cast to avoid hicpp-signe-bitwise - #529
Merged
Merged
Conversation
If key is used as a char or an element of string_view, it can be negative depending on its contents. To avoid hicpp-signe-bitwise in clang-tidy, it can be recast as a uint8_t. Closes #528.
mabruzzo
approved these changes
Jul 21, 2026
mabruzzo
left a comment
mabruzzo
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me! Thanks for making this PR!
I'm not sure that this actually supports unicode characters, but that shouldn't come up.1
Footnotes
-
For some context, my concern is about C++ implementations where
charis equivalent tosigned char(the standard doesn't specify whethercharis equivalent tosigned charorunsigned char). It might work out (I'm not sure off the top of my head), but the safer thing to do is to use C++20's,std::bit_castrather than a regular cast. This is all moot since we currently use C++17 and unicode probably won't come up. ↩
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If key is used as a char or an element of string_view, it can be negative depending on its contents. To avoid hicpp-signe-bitwise in clang-tidy, it can be recast as a uint8_t. Closes #528.