Skip to content

[Scala3] Handle private Bundle parameters#5153

Merged
adkian-sifive merged 1 commit intomainfrom
scala3-bundlephase-private-constructor-params
Jan 16, 2026
Merged

[Scala3] Handle private Bundle parameters#5153
adkian-sifive merged 1 commit intomainfrom
scala3-bundlephase-private-constructor-params

Conversation

@adkian-sifive
Copy link
Copy Markdown
Contributor

@adkian-sifive adkian-sifive commented Jan 15, 2026

This was a missing feature from the plugin where it would skip Bundles with inaccessible constructor parameters.

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • Internal or build-related (includes code refactoring/cleanup)

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash) and clean up the commit message.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@adkian-sifive adkian-sifive added the Scala 3 Changes related to upgrading to Scala 3 label Jan 15, 2026
Comment on lines +94 to +95
val paramSymss = record.symbol.primaryConstructor.paramSymss
.filterNot(_.exists(_.isType))
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between paramSymss and termParamss? It also seems weird to be filtering that things aren't types

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also up above we get the contructor with:

    val template = record.rhs.asInstanceOf[tpd.Template]
    val primaryConstructorOpt = Option(template.constr)

Should we keep that or just use record.symbol.primaryConstructor throughout?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

paramSymss is everything in a class constructor: type params, value params+types, implicit params. termParamss are ValDefs in the constructor. the filter just skips over the type params

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also up above we get the contructor with:

iirc that's how it's done in the compiler

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adkian-sifive adkian-sifive merged commit 53fe61a into main Jan 16, 2026
28 checks passed
@adkian-sifive adkian-sifive deleted the scala3-bundlephase-private-constructor-params branch January 16, 2026 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scala 3 Changes related to upgrading to Scala 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants