fix: align CJK ASCII hyphen wrapping with browsers - #215
Conversation
|
Nice fix — the numeric-minus handling (gluing One clarifying question before it lands: the numeric-minus logic is CJK-gated, but the Not a blocker — just want to be sure the global set change is intentional and side-effect-free outside CJK. |
|
Followed up on my own question — I traced it and diffed both branches, and the answer is reassuring: the global Trace — all three consult sites are CJK-guarded or already shadowed:
Empirical — built both branches (bun runs the TS sources directly with the repo's fake-canvas backend) and diffed
So this is safe as-is. The only optional polish would be gating the set membership behind a CJK check (or adding a non-CJK no-regression test) to make the intent legible — purely cosmetic, not a correctness issue. Nice fix. |
|
Thank you @pyrex41 so much for digging into this so thoroughly, and especially for following up on your own question with the trace, branch diff, width sweeps, fuzzing, and positive control. That saved me a ton of legwork and gave me much more confidence that the global kinsokuStart addition is truly inert outside CJK. |
fix #214