Remove the dead AppVeyor CI configuration - #23
Open
tas50 wants to merge 1 commit into
Open
Conversation
AppVeyor has not run for this repository in years and the config could not run even if it were triggered: - `image: Visual Studio 2019` is a retired build image - Ruby 2.7 and 3.0 are below the gemspec's `required_ruby_version >= 3.1` - `branches: only: master` never matches, the default branch is `main` - `clone_folder: c:\projects\winrm-fs` predates the gem rename Also drop the AppVeyor status badge from the README, which pointed at the pre-fork winrb/winrm-fs project, and the appveyor.yml entry from the repo tree in the Copilot instructions. Integration specs are now unreachable from CI. Wiring `rake integration` up to a Windows GitHub Actions runner is tracked separately. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AppVeyor has not run for this repository in years, and the config could not run even if something did trigger it:
image: Visual Studio 2019is a retired build imagerequired_ruby_version >= 3.1branches: only: masternever matches — the default branch ismainclone_folder: c:\projects\winrm-fspredates the rename tochef-winrm-fsAlso removed:
winrb/winrm-fsprojectappveyor.ymlline from the repo tree in.github/copilot-instructions.mdNote on integration tests
AppVeyor was the only CI that ever ran
rake integration, so the 305 lines of integration specs inspec/integration/are now unreachable from CI. They were already unreachable in practice — nothing has run them since the branch filter stopped matching. Wiringrake integrationup to a Windows GitHub Actions runner (which canEnable-PSRemotingand test against localhost, exactly as AppVeyor did) is worth doing as a follow-up;spec_helper.rbalready reads thewinrm_endpoint/winrm_user/winrm_passwordenv vars needed for it.The README also still carries a dead
travis-ci.orgbadge and awinrm-fsgem-version badge, both pointing at the pre-fork project. Left alone here to keep this PR to one topic.