Repository navigation
Reconverse atomic fetch and inc - #4030
Merged
ritvikrao merged 2 commits intoOct 10, 2026
Merged
Conversation
Moves contrib/reconverse from b30ad31 to c86daca (branch fix-atomic-fetch-and-inc), which makes the plain-integer overload of CmiMemoryAtomicFetchAndInc an atomic add, as it is in stock Converse. NAMD's PME pencils count node-group message arrivals in plain ints with this macro; the lost increments hung every STMV 8M GPU-offload run on Frontier at 8 nodes or more. The bump also picks up the reconverse main commits between the old pointer and the fix, which the Frontier builds were already using: 1dbf901 Registered scheduler: drain the thread queue before the slot sweep (#259) 5bfca1a Fix three false-sharing hot spots: LCI2 progress locks, CsdNodeQueueLen, cutOffPoints (#264) 9462529 ping_ack: parse arguments once per process, before PE 0 allocates (#266) 953eee9 IPC implementation in Reconverse (#246) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The previous commit pinned the fix on its review branch (c86daca). It is now squash-merged into reconverse main as 2e5775d, so pin that instead; the branch commit will not stay reachable once the branch is deleted. The code is identical to c86daca; the merge only dropped a comment. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
lvkale
approved these changes
Oct 10, 2026
lvkale
left a comment
lvkale
left a comment
Contributor
There was a problem hiding this comment.
Seems fine. It will get IPC and other merged changes as well, i think.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updating the Reconverse pin, because I had to fix a bug in atomic fetch and incs in Reconverse (exposed by running NAMD, refer to Reconverse commit 2e5775