Repository navigation
Reject --enable-randomized-msgq on reconverse builds; manual points at +randomized_msgq - #4029
Merged
lvkale merged 2 commits intoOct 12, 2026
Merged
Conversation
The option only affects classic Converse's scheduler queue, which reconverse builds do not compile, so it was accepted and did nothing. Reconverse randomizes at run time with +randomized_msgq, so the configure step now says so and stops. Manual updated. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This was referenced Oct 11, 2026
ritvikrao
approved these changes
Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
--enable-randomized-msgq(CMakeRANDOMIZED_MSGQ->CMK_RANDOMIZED_MSGQ) only changes classic Converse's scheduler queue (src/conv-core/msgq.h), which reconverse builds do not compile, so on reconverse the option was accepted and did nothing. Reconverse now provides randomization as a run-time flag,+randomized_msgqwith optional+randomized_seed <N>(charmplusplus/reconverse#269).This PR makes configure stop with a message when both
RECONVERSEandRANDOMIZED_MSGQare set, and adds a paragraph to the "Randomized Message Queueing" section of the manual describing the reconverse run-time flags../build charm++ reconverse-darwin-arm8 --with-production --enable-randomized-msgq -j8:Without the flag, configure completes ("Configuring done", "Build files have been written") and compilation starts as before.
🤖 Generated with Claude Code