-
Notifications
You must be signed in to change notification settings - Fork 980
docs: clarify Python compatibility and reduce README redundancy #3638
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Satyajit Bhola <satyajitbhola582@gmail.com>
38f53cc to
0362571
Compare
|
Does this PR solve a particluar issue? It seems like you may have been looking at #3441 but it doesnt appear to be referenced/linked here at all |
thanks for pointing that out This PR partially addresses #3441 by clarifying supported Python versions It does not update the environment setup tooling (e.g., switching from venv |
Signed-off-by: Satyajit <satyajitbhola582@gmail.com>
This incompatibility is likely going to be fixed in #3534 so saying this in the README is going to quickly become redundant and need fixing again. Can you take a look at the other PRs linked in #3441 to see how your changes relate to others that have already been submitted (i.e. please try to work with the contributors of those other issues to make one PR as much as possible)? Having to look across multiple PRs for the same issue massively slows down review time I will also add some comments in the underlying issue about what I hope to see as a resolution for this issue |
Thanks for the context! that makes sense. My intent here was mainly to reduce README redundancy and clarify the current state of Python support as it exists today. I see your point that explicitly calling out the 3.12 incompatibility may become outdated if #3534 lands soon. I’ll review the other PRs linked to #3441 and the comments you add there. Happy to adjust this PR to better align with the agreed direction (e.g. removing or softening the 3.12 note), or to narrow the scope strictly to redundancy cleanup if that’s preferred. |
This PR improves the README by:
No functional changes.