-
Notifications
You must be signed in to change notification settings - Fork 981
Add health checks to Rabbit and Postgres to prevent race conditions #3613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
this is now part of our prod config. |
|
Copilot analysis of failed job:
theory: Seems to be due to the container not running as root |
sgoggins
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…efore augur starts. This avoids some race conditions with the startup process that could create issues, especially on first initialization. Co-Authored-By: guptapratykshh <[email protected]> Co-Authored-By: Sukuna0007Abhi <[email protected]> Signed-off-by: Adrian Edwards <[email protected]>
988d8a6 to
b346bba
Compare
|
@MoralCode : DO we think we should solve for this cookie error? It seems like it needs to be fix for the docker deployments to remain stable. |
|
@MoralCode : I can see running as root would likely fix the podman issue, but since we don't care about rabbitmq persisting its queues across startups for Augur, I think we could configure it to use the |
|
If we want to just merge the postgres health check and gitconfig error fix, we should reopen #3559 since thats what that PR does. I have not looked into this CI rabbit issue, so maybe the rabbit health check should be a separate PR. |
This avoids some race conditions with the startup process that could create issues, especially on first initialization as noted in #3548 but also observed by me (rabbit had some
Description
This PR fixes #3548
This pr also fixes #3612 (i think)
Thanks to @Sukuna0007Abhi and @guptapratykshh for submitting PRs on this that each addressed different parts of the issue. This PR is the combination of both works and you have both been credited in the commit message
Notes for Reviewers
Signed commits