Skip to content

Small fix. #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
allomov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Small fix. #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
038a35c
add .python-version to gitignore
allomov Sep 26, 2014
56f7d3a
merge master after changes in .gitignore
allomov Sep 26, 2014
1552ad5
replace len(..) > 0 with simple casting to boolean
allomov Sep 26, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,10 @@ output/*/index.html
docs/_build
.ropeproject

# pyenv
.python-version

# Generated test charms
cloudfoundry-r*
output-v*.yaml

2 changes: 1 addition & 1 deletion charmhelpers/core/services/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ def is_ready(self):
"""
Returns True if all of the `required_keys` are available from any units.
"""
ready = len(self.get(self.name, [])) > 0
ready = !!self.get(self.name, [])
if not ready:
hookenv.log('Incomplete relation: {}'.format(self.__class__.__name__), hookenv.DEBUG)
return ready
Expand Down