Async#422
Merged
Merged
Conversation
Theodlz
reviewed
May 18, 2026
| "phonenumbers>=8.12.15", | ||
| "psycopg2-binary>=2.8.6", | ||
| "psycopg[binary]>=3.2.0", | ||
| "greenlet>=3.0.0", |
Collaborator
There was a problem hiding this comment.
what does greenlet do? Asking because I see no explicit import to it here.
Collaborator
Author
There was a problem hiding this comment.
It is the dependency for the async stuff. Could also import this as sqlalchemy[asyncio].
Collaborator
There was a problem hiding this comment.
yes that's definitely a lot clearer. Thanks
antoine-le-calloch
approved these changes
Jun 12, 2026
antoine-le-calloch
left a comment
antoine-le-calloch
left a comment
Contributor
There was a problem hiding this comment.
LGTM, one small comment.
Comment on lines
+9
to
+16
| from baselayer.app.models import ( # noqa: F401 | ||
| DBSession, | ||
| Role, | ||
| Token, | ||
| User, | ||
| async_plain_session_factory, | ||
| ) | ||
|
|
Contributor
There was a problem hiding this comment.
async_plain_session_factory can be remove here.
Contributor
|
@mcoughlin another comment is that the sync stuff pass |
Collaborator
Author
|
@antoine-le-calloch Got that one too, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
async capabilities on top of #421