Refactor Celo hardfork overrides to use nil-guarded defaults#423
Closed
piersy wants to merge 1 commit intocelo-rebase-16from
Closed
Refactor Celo hardfork overrides to use nil-guarded defaults#423piersy wants to merge 1 commit intocelo-rebase-16from
piersy wants to merge 1 commit intocelo-rebase-16from
Conversation
Use nil-guards in applyCeloHardforks so that values already set by the superchain registry or rollup config file are not overwritten, and CLI --override.<fork> flags always win. Add Celo Sepolia isthmus override. See celo-org/celo-blockchain-planning#1346
Author
|
Closing for now as I think I have a better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use nil-guards in applyCeloHardforks so that values already set by the superchain registry or rollup config file are not overwritten, and CLI --override. flags always win. Add Celo Sepolia isthmus override.
This approach removes our reliance on the superchain registry, since we cannot safely rely on our updates to the superchain registry being merged in a timely manner.
For this to work correctly we need to have a similar change in op-geth see celo-org/op-geth#478
See https://github.com/celo-org/celo-blockchain-planning/issues/1346