Refactor bbox to allow performance testing of transpose storage#2400
Merged
Conversation
Test summary 6 050 files 9 807 suites 19m 23s ⏱️ Results for commit c5d3a0d. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2400 +/- ##
===========================================
+ Coverage 87.22% 87.23% +0.01%
===========================================
Files 1396 1396
Lines 44025 44050 +25
Branches 13791 13303 -488
===========================================
+ Hits 38400 38427 +27
+ Misses 4546 4397 -149
- Partials 1079 1226 +147
🚀 New features to boost your workflow:
|
Contributor
|
@sethrj did you look at timing for this? |
Member
Author
|
@elliottbiondo This should compile down to the same runtime code I think (some of the utils are slightly different but are only used in setup) so this one should have no performance impact. I'm waiting on ExCL to come back up to run the timing, and additionally check the timing of the bbox transpose. |
elliottbiondo
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many/most of the runtime bounding box algorithms loop over axes on the outside and bounds on the inside. This updates the bounding box internals to allow us to switch the axis/bound storage in the bounding box by writing most code as
box.point(bound, axis).Extents3type to allow construction/use by lo/hi pairs for each axispoint(b, ax)in algorithmspointaccessors to allowldg(&bbox.point(b, ax))in future testing