Skip to content

feat(backend-tests): [sep-12] write e2e tests for pre-signed url uplo…#677

Merged
Ceejaytech25 merged 1 commit into
ceejaylaboratory:mainfrom
heymide:feature/issue-561-sep-12-write-e2e-tests-for-pre-signed-url-upload-flow
Jul 4, 2026
Merged

feat(backend-tests): [sep-12] write e2e tests for pre-signed url uplo…#677
Ceejaytech25 merged 1 commit into
ceejaylaboratory:mainfrom
heymide:feature/issue-561-sep-12-write-e2e-tests-for-pre-signed-url-upload-flow

Conversation

@heymide

@heymide heymide commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Close: #561

Summary of Changes

  1. Updated backend/src/api/controllers/sep12.controller.test.ts to add mocks for:
    • storageProvider.service (mock S3-like storage service)
    • uploadStore.service (in-memory upload record store)
    • config/env (SEP-12 max file size configuration)
  2. Added tests for getUploadUrl method :
    • Happy path: successfully returns a pre-signed URL
    • Missing required parameters returns 400
    • Invalid content-type returns 400
    • Oversized file (exceeds max allowed size) returns 400
  3. Added tests for confirmUpload method :
    • Happy path: successfully confirms upload and updates status to COMPLETED
    • Missing required parameters returns 400
    • Non-existent upload record returns 404
    • Account mismatch returns 403
    • File not found in storage returns 422
      The network issue is preventing us from installing dependencies right now, but the test implementation itself is complete and follows the project's existing test conventions!

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@heymide Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@heymide

heymide commented Jun 27, 2026

Copy link
Copy Markdown
Contributor Author

Done, Close: #677

@Ceejaytech25

Copy link
Copy Markdown
Contributor

Nice implementation, LGTM!

@Ceejaytech25 Ceejaytech25 merged commit 42f8911 into ceejaylaboratory:main Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[SEP-12] Write E2E Tests for Pre-signed URL Upload Flow

2 participants