Skip to content

fix: ensure the admin role stabilizes for self-managed stacksets - #918

Merged
cdklabs-automation merged 3 commits into
mainfrom
fix/admin-role-depends
Sep 30, 2026
Merged

cdklabs-automation merged 3 commits into
mainfrom
fix/admin-role-depends

Conversation

@gudipati

Copy link
Copy Markdown
Contributor

Taking over PR #678

Looks like #439 tackles the same problem, however, I think DependsOn is sufficient and is typically what is used in aws-cdk-lib, e.g. https://github.com/aws/aws-cdk/blob/0546ec24c5fa60cae41c6561d7178de7a403a713/packages/%40aws-cdk/aws-kinesisanalytics-flink-alpha/lib/application.ts#L1030

For anyone looking for a workaround with the current release, you can add the dependency like so:

if (selfManagedStackSet.role) {
  selfManagedStackSet.node.addDependency(selfManagedStackSet.role);
}

fixes #438, supersedes #439

Co-Authored-By: Martin Madsen mj@factbird.com

@github-actions

Copy link
Copy Markdown
Contributor

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@ozelalisen ozelalisen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments:

Comment thread test/integ.stack-set.ts.snapshot/integ-stackset-test.template.json Outdated
Comment thread test/stack-set.test.ts

@ozelalisen ozelalisen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cdklabs-automation
cdklabs-automation added this pull request to the merge queue Sep 30, 2026
Merged via the queue into main with commit 8b3c502 Sep 30, 2026
12 checks passed
@cdklabs-automation
cdklabs-automation deleted the fix/admin-role-depends branch September 30, 2026 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Race condition when using self managed deployment type

4 participants