Repository navigation
fix(test): pin toolchain in package-integrity fixtures - #2055
Closed
aemada-aws wants to merge 1 commit into
Closed
aemada-aws wants to merge 1 commit into
aemada-aws wants to merge 1 commit into
Conversation
The package-integrity tests scaffold projen projects and run `npx projen build` inside them. The fixtures pinned no versions, so projen generated "typescript": "*", "jest": "*" and "ts-jest": "*", resolving the latest published versions at test time. TypeScript 7.x now resolves via "*" and is incompatible with ts-jest 29 (peer typescript ">=4.3 <6"), so the nested build crashes with "Cannot read properties of undefined (reading 'readFile')" in ConfigSet._resolveTsConfig, producing no dist/ and failing the suite. Pin the scaffolded projects to a compatible combination (typescript ~5.8.0, jest ^29, ts-jest ^29) so the integrity tests build deterministically and stop blocking the auto dependency-upgrade PRs.
cdklabs-automation
enabled auto-merge
July 20, 2026 14:22
auto-merge was automatically disabled
July 20, 2026 14:22
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
chore(deps)dependency-upgrade PRs (e.g. #2054) are stuck — the requiredbuildcheck fails on thepackage-integritytest suite (lib/__tests__/package-integrity/handler/integrity.test.ts:happy jsii,unhappy npm jsii,unhappy pypi jsii,happy ts).These tests scaffold throwaway projen projects and run
npx projen buildinside them. The fixture.projenrc.jsfiles pin no versions, so projen generates:which resolve the latest published versions at test time. TypeScript 7.0.2 now resolves via
*, butts-jest@29only supportstypescript ">=4.3 <6". The nested build therefore crashes:No
dist/is produced, so the outer assertions fail withENOENT ... /dist. This is repo-wide (affectsmainand every open PR), not specific to any dependency bump.Fix
Pin the scaffolded projects to a compatible combination in both fixtures:
Validation
Reproduced locally: with
*ranges → typescript7.0.2+ ts-jest29.4.11→readFilecrash. After pinning → typescript5.8.3+ jest29.7.0+ ts-jest29.4.11, and the scaffolded project's test step passes (Test Suites: 1 passed). CI will exercise the fullnpx projen buildin the integrity suite.