Remove unused global host statements in test_module_interceptor#80
Merged
Conversation
The `host` variable is set on the module object in `setup_module()` and only read (never assigned) in test functions, so `global` declarations are unnecessary. Add an explicit `host = None` at module level to satisfy flake8 F821 (undefined name) static analysis, since `host` is assigned dynamically at runtime via `module.host`. Fixes F824 violations introduced by pyflakes 3.2+. Signed-off-by: Julien Le Jeune <julien.le-jeune@ovhcloud.com>
Owner
|
Thanks, will deal with this very soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
hostvariable is set on the module object insetup_module()and only read (never assigned) in test functions, soglobaldeclarations are unnecessary. Add an explicithost = Noneat module level to satisfy flake8 F821 (undefined name) static analysis, sincehostis assigned dynamically at runtime viamodule.host. Fixes F824 violations introduced by pyflakes 3.2+.