Support push event by associating with open pull requests#54
Open
tockn wants to merge 2 commits intocatchpoint:masterfrom
Open
Support push event by associating with open pull requests#54tockn wants to merge 2 commits intocatchpoint:masterfrom
tockn wants to merge 2 commits intocatchpoint:masterfrom
Conversation
|
Hi @tockn, Thanks for your contribution and sorry for late reply. Could you please rebase your PR with latest changes? |
Author
|
@serkan-ozal Hi! I've resolved the conflicts! |
Contributor
|
Hey @tockn, Apologies for late reply and slow progress. Can you please rebase again and run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for the wonderful project! In this Pull Request, I have made changes to allow this action to be triggered by push events as well.
Previously, the action would retrieve pull request information from the context payload and, if present, comment with the results of the metrics. However, this was only possible with pull request events. With this change, if pull request information cannot be obtained from the context, the system now retrieves open pull requests associated with the sha and comments there. This modification allows the action to operate with push events as well.