Implement downloads#201
Conversation
The previous event didn't trigger on click.
cassidyjames
left a comment
cassidyjames
left a comment
There was a problem hiding this comment.
Awesome work! I did a quick pass over code style and am going to dogfood this for a while, but left some quick notes, mostly around indentation/whitespace.
| * | ||
| * Authored by: Adrian Cochrane <alcinnz@lavabit.com> | ||
| */ | ||
| namespace Ephemeral { |
There was a problem hiding this comment.
I typically avoid the extra indentation level and just namespace the class itself, i.e. Ephemeral.DownloadsButton. I think I'd like to do that here as well for consistency with the rest of the codebase.
There was a problem hiding this comment.
I differed for the sake of two helper classes, but I can make that adjustment.
|
It looks like a lot of the margins and whatnot didn't get carried over from the prototype branch as well. I can work on cleaning those up, but I just thought I'd share here for posterity. Prototype
This branch
|
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
Co-Authored-By: Cassidy James Blaede <cassidy@elementary.io>
|
I've gone over your feedback and incorporated it into my pull request. |
2 participants
Fixes #36
It matches your mockup, except it uses a ListBox for better keyboard input and nicer layout upon removing a download. And as requested it shows a Toast once the download has been completed.