fix: normalize line separators when initializing prompt editors#1229
Open
SunlitDev wants to merge 1 commit into
Open
fix: normalize line separators when initializing prompt editors#1229SunlitDev wants to merge 1 commit into
SunlitDev wants to merge 1 commit into
Conversation
Settings -> ProxyAI -> Prompts could appear to hang ("loading" forever) on
Windows when the plugin was built locally. Source .txt prompts checked out
with autocrlf=true ended up CRLF inside the JAR, and AbstractEditorPromptPanel
fed those CRLF strings straight into createDocument. IntelliJ then queued a
background write action per editor to normalize the document, but those WAs
sat blocked behind the modal Settings dialog's WriteIntentReadAction, each
hitting the 10-second BG-WA timeout.
Fix it at both ends:
- Wrap details.instructions with StringUtil.convertLineSeparators before
passing to createDocument, mirroring updateEditorText. This also protects
against pre-existing CRLF that may already live in persisted
CodeGPT_PromptsSettings.xml from older installs.
- Add a .gitattributes rule forcing src/main/resources/prompts/**/*.txt to
eol=lf so the same condition cannot reappear on future Windows builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Settings -> ProxyAI -> Prompts could appear to hang ("loading" forever) on Windows when the plugin was built locally. Source .txt prompts checked out with autocrlf=true ended up CRLF inside the JAR, and AbstractEditorPromptPanel fed those CRLF strings straight into createDocument. IntelliJ then queued a background write action per editor to normalize the document, but those WAs sat blocked behind the modal Settings dialog's WriteIntentReadAction, each hitting the 10-second BG-WA timeout.
Fix it at both ends: