add collect submission file feature#556
Open
lucaslyl wants to merge 3 commits into
Open
Conversation
richardhjtan
reviewed
May 8, 2026
Comment on lines
-64
to
-67
| if (!listingId || !listingRealm) { | ||
| throw new Error('Missing listingId or listingRealm'); | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Is the guard removed for reason?
Contributor
Author
There was a problem hiding this comment.
yes, the guard was deliberately removed — "requireInputFields" on line 55 already enforces the same contract, and the other commands(listing-use/remix) in this codebase consistently rely on that mechanism rather than duplicating the check manually in run()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linear: https://linear.app/cardstack/issue/CS-11087/collect-listing-image-assets-in-submission-file-export
Extends the submission file collection to include all listing images (the
images/images.*relationships), not just the thumbnail. Replacesthe narrow
extractThumbnailUrlhelper withextractListingAssetUrlswhich returns both the thumbnail URL and the full image URL array.
Also hoists the
sortedKnownRealmUrlssort out of thetoRepoPathNoExtclosure so it is computed once instead of on every URL, and removes the
now-redundant manual
listingId/listingRealmnull-check that wasalready enforced by
requireInputFields.