fix: check field type via C++ schema in from_dict to avoid a reference create - #407
Merged
Merged
Conversation
greatgitsby
changed the title
greatgitsby
force-pushed
the
from-dict-schema-cycle
branch
from
September 7, 2026 16:35
991a4b4 to
af1d012
Compare
…e cycle from_dict called self.schema.fields for str values, which builds _StructSchemaField wrappers that reference the schema, so every message built via kwargs stayed alive until a GC pass. Follow-up to capnproto#401, which only skipped the lookup for non-str values.
greatgitsby
force-pushed
the
from-dict-schema-cycle
branch
from
September 7, 2026 16:35
af1d012 to
e98ed61
Compare
Contributor
Author
|
lint seems to fail on my machine and CI, unrelated to this commit. |
Collaborator
|
Thanks! Sorry for the delay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
from_dictcalledself.schema.fieldsfor str values, which builds_StructSchemaFieldwrappers that reference the schema, so every message built viakwargsstayed alive until a GC pass. Follow-up to #401, which only skipped the lookup for non-str values.