feat(apps:builds:create): support ad hoc environment variables#134
Merged
feat(apps:builds:create): support ad hoc environment variables#134
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for passing ad hoc environment variables when creating an app build via the CLI, and forwards them to the API as adHocEnvironmentVariables.
Changes:
- Extend
CreateAppBuildDtowith optionaladHocEnvironmentVariables. - Add
--variable(repeatableKEY=VALUE) and--variable-file(simple.env-style) flags toapps builds create. - Parse/merge file + inline variables and include them in the build create request body.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/types/app-build.ts |
Adds adHocEnvironmentVariables?: Record<string, string> to the build creation DTO. |
src/commands/apps/builds/create.ts |
Introduces new CLI flags, parses variables from inline/file, and sends them to appBuildsService.create(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
create command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--variableflag (repeatableKEY=VALUE) to pass ad hoc environment variables when creating a build--variable-fileflag to load ad hoc environment variables from a.envfileadHocEnvironmentVariablesin the API request body