Skip to content

refactor: replace ops-tracing vendored libs by Charmlibs versions - #2739

Draft
dwilding wants to merge 4 commits into
canonical:mainfrom
dwilding:no-vendor-tracing
Draft

refactor: replace ops-tracing vendored libs by Charmlibs versions#2739
dwilding wants to merge 4 commits into
canonical:mainfrom
dwilding:no-vendor-tracing

Conversation

@dwilding

@dwilding dwilding commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Fully agent generated. I haven't reviewed yet.

@james-garner-canonical

Copy link
Copy Markdown
Contributor

IIRC Ops needs to register its copy of the tracing library object under a different name to avoid clashing with the objects registered by charms using the same lib. I don't recall where we made this edit in the vendored lib or where we could make this adjustment to the PyPI lib (monkeypatch? subclass?). But I guess an agent should be able to take a crack at it.

Presumably this is why the observability tests fail.

@tonyandrewmeyer

Copy link
Copy Markdown
Collaborator

IIRC Ops needs to register its copy of the tracing library object under a different name to avoid clashing with the objects registered by charms using the same lib. I don't recall where we made this edit in the vendored lib or where we could make this adjustment to the PyPI lib (monkeypatch? subclass?). But I guess an agent should be able to take a crack at it.

Presumably this is why the observability tests fail.

I misremembered which library it was, it's certificate transfer, the "internal" prefix. And it is definitely the cause for the observability test failure. I would also assume subclassing or similar can work around it.

@dwilding dwilding changed the title chore: replace ops-tracing vendored libs by Charmlibs versions refactor: replace ops-tracing vendored libs by Charmlibs versions Sep 9, 2026
@dwilding

dwilding commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

That was it, thanks! My agent added subclasses in f0b625a. (Again, not yet reviewed by me)

@dwilding

dwilding commented Sep 9, 2026

Copy link
Copy Markdown
Contributor Author

The Data Charm Tests failures are because the tracing lib was released too recently for Poetry (in downstream charm repos) to resolve. Should pass tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants