Skip to content

fix(cli): return nonzero exit code on error#565

Merged
JegadishD merged 2 commits into
canonical:mainfrom
Cellebyte:fix/return-code
May 28, 2026
Merged

fix(cli): return nonzero exit code on error#565
JegadishD merged 2 commits into
canonical:mainfrom
Cellebyte:fix/return-code

Conversation

@Cellebyte
Copy link
Copy Markdown
Contributor

@Cellebyte Cellebyte commented Dec 16, 2025 •
edited
Loading

Description

This is the successor of https://github.com/canonical/netplan/pull/551/changes.

Checklist

  • Runs make check successfully.
  • Retains code coverage (make check-coverage).
  • New/changed keys in YAML format are documented.
  • (Optional) Adds example YAML for new feature.
  • (Optional) Closes an open bug in Launchpad. LP#2104373

@Cellebyte Cellebyte force-pushed the fix/return-code branch 8 times, most recently from 9d35107 to 250ce2b Compare December 16, 2025 14:48
@Cellebyte
Copy link
Copy Markdown
Contributor Author

Cellebyte commented Dec 22, 2025

@slyon is this a breaking API change?

vincele
vincele approved these changes Dec 30, 2025
View reviewed changes
Copy link
Copy Markdown

@vincele vincele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cellebyte Cellebyte mentioned this pull request Mar 24, 2026
Closed
5 tasks
@benhoyt
Copy link
Copy Markdown
Collaborator

benhoyt commented Mar 24, 2026

Thanks for the update on this. Sorry for not getting to this earlier -- there's been a number of staffing changes here and we're coming up to speed on netplan. We hope to review this properly (with context) in the next couple of weeks, but at first look (and the LP issue) it looks reasonable.

@benhoyt benhoyt added the needs review soon A PR marked as needing review soon, for some value of "soon". label Mar 24, 2026
@Cellebyte
Copy link
Copy Markdown
Contributor Author

Cellebyte commented May 20, 2026

@benhoyt do you have a status update on this topic here?

@benhoyt
Copy link
Copy Markdown
Collaborator

benhoyt commented May 20, 2026

We've just got back from our company conference and have allocated one person full time on this project for the next few months, so we'll have more time to review these now. There are a few things to do before we start on PR review, but I think we'll get there soon. @JegadishD, this looks like a relatively straight-forward issue and PR to review -- perhaps a good place to start when you get to PR review?

JegadishD
JegadishD reviewed May 21, 2026
View reviewed changes
Comment thread tools/run_asan.sh Outdated
@benhoyt benhoyt changed the title Return with exit-code 1 when having an error (LP: #2104373) fix(cli): return nonzero exit code on error May 27, 2026
Cellebyte added 2 commits May 27, 2026 10:46
@Cellebyte
Return with exit-code 1 when having an error
b22f823 
Signed-off-by: Marcel Fest <marcel.fest@telekom.de>
@Cellebyte
fix: remove exclusion for OpenStack files as the tests should pass
fe7f68d 
Signed-off-by: Marcel Fest <marcel.fest@telekom.de>
@JegadishD JegadishD self-requested a review May 27, 2026 09:52
@JegadishD JegadishD merged commit 901eeca into canonical:main May 28, 2026
13 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JegadishD JegadishD JegadishD approved these changes

+1 more reviewer

@vincele vincele vincele approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs review soon A PR marked as needing review soon, for some value of "soon".

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Cellebyte @benhoyt @vincele @JegadishD