[MISC] Allow control chars on cluster/clusterset status output dict - #75
Open
paulomach wants to merge 1 commit into
Open
[MISC] Allow control chars on cluster/clusterset status output dict#75paulomach wants to merge 1 commit into
paulomach wants to merge 1 commit into
Conversation
On some transient cases, cluster/clusterset output fields instanceErrors and applierErrors can contain control chars, breaking the json conversion.
astrojuanlu
approved these changes
Jul 31, 2026
astrojuanlu
left a comment
astrojuanlu
left a comment
Contributor
There was a problem hiding this comment.
If strict is false (True is the default), then control characters will be allowed inside strings.
👍🏼
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, cluster/clusterset output fields
instanceErrorsandapplierErrorscan contain control chars, breaking the json conversion.
On the charms, this breaks hook execution with uncaught
JSONDecodeErrorexactly when a self-healing procedure is needed.Setting
strict=Falseconfigure theJSONDecoderto ignore control characters.