Skip to content

feat: error on default command#422

Merged
mr-cal merged 3 commits intomainfrom
work/SNAPCRAFT-1194-default-command-error
Mar 5, 2026
Merged

feat: error on default command#422
mr-cal merged 3 commits intomainfrom
work/SNAPCRAFT-1194-default-command-error

Conversation

@mr-cal
Copy link
Contributor

@mr-cal mr-cal commented Mar 2, 2026

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint && make test?

Adds an allow_default_command parameter to the Dispatcher to allow using a default command.

This is an opt-in flag, so there are no behavioral changes for existing apps.

Tested downstream in canonical/snapcraft#6074

Unblocks canonical/snapcraft#5673
(SNAPCRAFT-1194)

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
@mr-cal mr-cal marked this pull request as ready for review March 3, 2026 22:43
@mr-cal mr-cal requested review from a team, medubelko and tigarmo as code owners March 3, 2026 22:43
@mr-cal mr-cal requested review from bepri and removed request for a team March 3, 2026 22:48
mr-cal added 2 commits March 5, 2026 07:37
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Copy link
Contributor

@medubelko medubelko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLI changes LGTM.

@mr-cal mr-cal merged commit 7b630a9 into main Mar 5, 2026
20 checks passed
@mr-cal mr-cal deleted the work/SNAPCRAFT-1194-default-command-error branch March 5, 2026 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants