Spotlight header indicator is icon-only#259
Merged
Merged
Conversation
Drop the desktop "Spotlight" label from SpotlightIndicator; the chip is now icon-only on every breakpoint (label always SR-only, title tooltip carries the pointer affordance). The visible label distracted and stole horizontal space from the breadcrumb and other header controls, and the solid fill plus present-only-when-on already carry awareness. Sync the rationale into ADR 0033's header-indicator note and the component JSDoc so both match the shipped design. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughSpotlightIndicator now renders as an icon-only header chip at every breakpoint, with “Spotlight” retained as screen-reader-only text. The component comments, ADR, agent guidance, and changeset describe the updated behavior. ChangesSpotlight indicator presentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The spotlight header chip drops its "Spotlight" text label on desktop and is now icon-only on every breakpoint. The visible label distracted and stole horizontal space from the breadcrumb and other header controls.
Changes
SpotlightIndicatorrenders icon-only everywhere — the label is always an SR-only span, with thetitletooltip carrying the text affordance for pointer users.Test plan
e2e/spotlight.spec.tstargets[data-spotlight-indicator], not the visible text, so its indicator coverage is unaffected.Summary by CodeRabbit
UI Improvements
Documentation