feat(dvm): add NIP-89 handler recommendation and information kinds - #737
Merged
Merged
Conversation
Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
Signed-off-by: Priyanshubhartistm <bhartipriyanshustm@gmail.com>
🦋 Changeset detectedLatest commit: eb7945d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
Coverage is 71.334% — Priyanshubhartistm:feat/dvm-nip89-discovery into cameri:main. No base build found for |
cameri
approved these changes
Aug 25, 2026
There was a problem hiding this comment.
🟢 Approval recommended
The constants are correct and the tests comprehensively verify the intended passive behavior.
Pull request overview
Adds passive NIP-89 discovery support by naming existing parameterized-replaceable event kinds and verifying relay behavior.
Changes:
- Adds constants for kinds 31989 and 31990.
- Adds strategy-routing unit tests.
- Adds integration coverage for storage, replacement, and kind-filtered discovery.
File summaries
| File | Description |
|---|---|
src/constants/base.ts |
Defines NIP-89 event kinds. |
test/unit/factories/event-strategy-factory.spec.ts |
Verifies strategy routing. |
test/integration/features/nip-89/nip-89.feature |
Defines discovery scenarios. |
test/integration/features/nip-89/nip-89.feature.ts |
Implements NIP-89 test steps. |
.changeset/dvm-nip89-discovery.md |
Records the feature release. |
Review details
- Files reviewed: 5/5 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds NIP-89 discovery for DVM job requests: named
EventKindsconstantsHANDLER_RECOMMENDATION = 31989andHANDLER_INFORMATION = 31990, plus tests confirming both are already passively accepted, served, and replaced correctly.ParameterizedReplaceableEventStrategyalready handles create/replace/serve for them no new handler code, only named constants for clarity.event-strategy-factory.spec.tsconfirm both kinds route toParameterizedReplaceableEventStrategy.test/integration/features/nip-89/) cover, for each kind: create + serve, replace-on-d-tag-collision, and kind-onlyREQfilter discovery.Related Issue
Part of #639. Closes #736.
Motivation and Context
Job requests (#729), persistence (#727), and dispatch (#731) exist, but there was no way for clients to discover which DVMs a relay's workers can talk to. Passive accept-and-serve (over relay-authored handler-info with a heartbeat) was the scope confirmed with the maintainer.