Skip to content

fix: hide duplicate mobile sidebar menu icon - #126

Merged
artus9033 merged 1 commit into
callstack:mainfrom
JKobrynski:fix/bugs-from-react-native-paper
Jul 2, 2026
Merged

artus9033 merged 1 commit into
callstack:mainfrom
JKobrynski:fix/bugs-from-react-native-paper

Conversation

@JKobrynski

Copy link
Copy Markdown
Contributor

Summary

Fixes a duplicated mobile sidebar menu icon that was reported on Slack.

In newer Rspress versions, the mobile sidebar Menu button renders its built-in icon as an inline svg. The theme already adds its own menu icon via ::before, but only hid the old img icon shape. As a result, both icons could appear next to each other on mobile.

This updates the CSS rule to hide both img and svg children inside .rp-sidebar-menu__left, leaving only the theme-provided icon visible.

Test plan

  • Open the tester app on a mobile viewport.
  • Visit a sidebar page, for example /nav/section-a/section-a-intro.
  • Verify the sticky Menu row shows only one menu icon.
  • Tap Menu and verify the sidebar still opens correctly.
  • Visit /test/guide on mobile and verify:
    • Menu still opens the sidebar.
    • Contents still opens the outline panel.
    • The top mobile nav hamburger still opens the nav menu.
  • Switch to desktop width and verify:
    • The regular sidebar is visible.
    • The mobile sticky menu row is collapsed/hidden.
    • The desktop nav still looks unchanged.
  • Ran pnpm lint.
  • Ran pnpm typecheck.

@artus9033
artus9033 merged commit 4563983 into callstack:main Jul 2, 2026
1 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants