Repository navigation
fix: hide duplicate mobile sidebar menu icon - #126
Merged
artus9033 merged 1 commit intoJul 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a duplicated mobile sidebar menu icon that was reported on Slack.
In newer Rspress versions, the mobile sidebar
Menubutton renders its built-in icon as an inlinesvg. The theme already adds its own menu icon via::before, but only hid the oldimgicon shape. As a result, both icons could appear next to each other on mobile.This updates the CSS rule to hide both
imgandsvgchildren inside.rp-sidebar-menu__left, leaving only the theme-provided icon visible.Test plan
/nav/section-a/section-a-intro.Menurow shows only one menu icon.Menuand verify the sidebar still opens correctly./test/guideon mobile and verify:Menustill opens the sidebar.Contentsstill opens the outline panel.pnpm lint.pnpm typecheck.